This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author zach.ware
Recipients christian.heimes, pitrou, serhiy.storchaka, vstinner, zach.ware
Date 2013-10-18.17:20:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1382116837.94.0.0798724056162.issue19259@psf.upfronthosting.co.za>
In-reply-to
Content
Even after reading through #15061, I still wonder why _compare_digest is in _operator at all.  It makes even less sense to me to put a Python implementation in operator; shouldn't the Python implementation be in the module that actually uses it?

Branching from the recent discussion[1] about where to place a PBKDF2 wrapper, it would make the most sense to me to move hmac into hashlib as suggested and move _compare_digest into hashlib's C somewhere.

For the record, the reason I didn't try to implement a _compare_digest in operator.py in the first place was because #15061 made it pretty clear that operator.c was just a convenient place to stick the function, not that it was supposed to actually be part of the operator module.
History
Date User Action Args
2013-10-18 17:20:37zach.waresetrecipients: + zach.ware, pitrou, vstinner, christian.heimes, serhiy.storchaka
2013-10-18 17:20:37zach.waresetmessageid: <1382116837.94.0.0798724056162.issue19259@psf.upfronthosting.co.za>
2013-10-18 17:20:37zach.warelinkissue19259 messages
2013-10-18 17:20:37zach.warecreate