Message198318
+ except:
+ pass
...
+ except TypeError:
+ return None
I don't understand these try/except. First, "except: pass" must never be used, only catch specific exceptions (ex: AttributeError). Can you explain why you expect a TypeError?
If your patch fixes a bug, you must add a new unit test to test_pydoc to check for non-regression. |
|
Date |
User |
Action |
Args |
2013-09-23 08:06:50 | vstinner | set | recipients:
+ vstinner, ping, ncoghlan, kjohnson, brianvanden, ajaksu2, eric.araujo, akitada, mpg, sunfinite |
2013-09-23 08:06:50 | vstinner | set | messageid: <1379923610.25.0.176354587394.issue1185124@psf.upfronthosting.co.za> |
2013-09-23 08:06:50 | vstinner | link | issue1185124 messages |
2013-09-23 08:06:50 | vstinner | create | |
|