Message190520
This code is pretty broken. I don't think ttys are ever seekable, so the os.fdopen has probably been always failing since 3.0. It thus always leaks an fd to '/dev/tty' if the first os.open succeeds. The whole function should probably be rewriten to work with byte streams encoding the prompt with os.device_encoding(tty_fd) falling back on locale.getpreferredencoding(). |
|
Date |
User |
Action |
Args |
2013-06-03 07:02:55 | benjamin.peterson | set | recipients:
+ benjamin.peterson, alex, nikratio, vajrasky |
2013-06-03 07:02:55 | benjamin.peterson | set | messageid: <1370242975.08.0.34102591553.issue18116@psf.upfronthosting.co.za> |
2013-06-03 07:02:55 | benjamin.peterson | link | issue18116 messages |
2013-06-03 07:02:54 | benjamin.peterson | create | |
|