Message190177
Mark: if you know Python you can answer that question yourself by reading the code of the subprocess and os modules.
From a fairly short glance at the code I'd say that _wrap_close is not obsolete. It is a wrapper about a file object for the stdout or stdin stream of a Popen object (depending on the last argument of os.popen), and when _wrap_close.close is called it closes the wrapped stream, then waits for the subprocess to die and returns a *transformation* of the exitcode attribute.
If my interpretation of the _wrap_close is correct this issue can be closed as invalid (the code cannot be cleaned up without changing functionality) |
|
Date |
User |
Action |
Args |
2013-05-28 06:53:27 | ronaldoussoren | set | recipients:
+ ronaldoussoren, pitrou, eric.araujo, BreamoreBoy, offby1 |
2013-05-28 06:53:27 | ronaldoussoren | set | messageid: <1369724007.34.0.914224921721.issue11965@psf.upfronthosting.co.za> |
2013-05-28 06:53:27 | ronaldoussoren | link | issue11965 messages |
2013-05-28 06:53:26 | ronaldoussoren | create | |
|