Message18910
Logged In: YES
user_id=6606
I can verify this issue on Solaris 10 (SunOS 5.10). Not
only does this code seem unnecessary, but there is no
configury nor make magic which _can_ ever set the SOLARIS
preprocessor define. If I run 'make' as follows, I can
trigger a hard compilation error:
[Python-2.4.2]$ make CFLAGS='$(BASECFLAGS) $(OPT)
-DSOLARIS=true'
...
In file included from ./Include/Python.h:55,
from Objects/complexobject.c:8:
./Include/pyport.h:382: error: conflicting types for
'gethostname'
/usr/include/unistd.h:319: error: previous declaration of
'gethostname' was here./Include/pyport.h:382: error:
conflicting types for 'gethostname'
/usr/include/unistd.h:319: error: previous declaration of
'gethostname' was here*** Error code 1
make: Fatal error: Command failed for target
`Objects/complexobject.o'
I recommend removing this snippet from pyport.h:
--- Include/pyport.h (revision 41772)
+++ Include/pyport.h (working copy)
@@ -372,11 +372,6 @@
in platform-specific #ifdefs.
**************************************************************************/
-#ifdef SOLARIS
-/* Unchecked */
-extern int gethostname(char *, int);
-#endif
-
#ifdef __BEOS__
/* Unchecked */
/* It's in the libs, but not the headers... - [cjh] */
|
|
Date |
User |
Action |
Args |
2007-08-23 14:18:08 | admin | link | issue837046 messages |
2007-08-23 14:18:08 | admin | create | |
|