This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author zach.ware
Recipients benjamin.peterson, eric.araujo, gregmalcolm, r.david.murray, zach.ware
Date 2013-04-24.15:29:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366817350.3.0.0113666626192.issue17830@psf.upfronthosting.co.za>
In-reply-to
Content
(Copying the nosy list from issue9607)

test_keyword has a couple of failures on Windows, all due to newline issues--see for example http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1845/steps/test/logs/stdio.  

test_keywords_py_without_markers_produces_error looks for a line ending with '\n', but Windows ends it with '\r\n'.  

test_real_grammar_and_keyword_file, on the other hand, doesn't fail on my machine, due to the hg eol extension being enabled, but the cause of failure is filecmp.cmp working only in binary mode and paying no attention to line endings.

The attached patch fixes both failures, with and without the eol extension, by using a private _compare_files function instead of filecmp.cmp.  The private function makes use of universal newlines to avoid issue.  Also, all instances of ``self.addCleanup(lambda ...)`` have had the lambda removed as suggested by Éric Araujo in msg187567.
History
Date User Action Args
2013-04-24 15:29:10zach.waresetrecipients: + zach.ware, benjamin.peterson, eric.araujo, r.david.murray, gregmalcolm
2013-04-24 15:29:10zach.waresetmessageid: <1366817350.3.0.0113666626192.issue17830@psf.upfronthosting.co.za>
2013-04-24 15:29:10zach.warelinkissue17830 messages
2013-04-24 15:29:09zach.warecreate