➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author orsenthil
Recipients dwoz, ezio.melotti, giampaolo.rodola, janssen, jeffknupp, orsenthil, pitrou, python-dev, r.david.murray
Date 2013-04-01.18:27:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1364840828.25.0.699843383793.issue17483@psf.upfronthosting.co.za>
In-reply-to
Content 
Antoine - I approached it from idea that check_hostname "as a setting" is allowed from HTTPSConnection (http/client.py) but it not controllable from urllib. Is there a case where it is useful in HTTPSConnection, but it should not be from urllib?

- Thanks for the changes. One comment on the  changeset 4ed8a8e781c3 

+        https_handler = HTTPSHandler(context=context, check_hostname=True)

check_hostname=True is redundant here. You could send the context and by default it checks the hostname.
History
Date User Action Args
2013-04-01 18:27:08orsenthilsetrecipients: + orsenthil, janssen, pitrou, giampaolo.rodola, ezio.melotti, r.david.murray, python-dev, jeffknupp, dwoz
2013-04-01 18:27:08orsenthilsetmessageid: <1364840828.25.0.699843383793.issue17483@psf.upfronthosting.co.za>
2013-04-01 18:27:08orsenthillinkissue17483 messages
2013-04-01 18:27:08orsenthilcreate