Message185233
possibly better patch - uses subprocess' quoting logic for argument handling:
diff -r 6fc9103d55f0 PCbuild/build_ssl.py
--- a/PCbuild/build_ssl.py Sun Mar 24 14:54:25 2013 -0700
+++ b/PCbuild/build_ssl.py Mon Mar 25 17:28:19 2013 +0200
@@ -47,10 +47,10 @@
# is available.
def find_working_perl(perls):
for perl in perls:
- fh = os.popen('"%s" -e "use Win32;"' % perl)
- fh.read()
- rc = fh.close()
- if rc:
+ import subprocess
+ try:
+ subprocess.check_call([perl, '-e', 'use Win32;'], shell=True)
+ except subprocess.CalledProcessError:
continue
return perl
print("Can not find a suitable PERL:") |
|
Date |
User |
Action |
Args |
2013-03-25 20:52:54 | Gabi.Davar | set | recipients:
+ Gabi.Davar, loewis, ocean-city, sable, tim.golden, brian.curtin, srid |
2013-03-25 20:52:53 | Gabi.Davar | set | messageid: <1364244773.96.0.0367993970987.issue10752@psf.upfronthosting.co.za> |
2013-03-25 20:52:53 | Gabi.Davar | link | issue10752 messages |
2013-03-25 20:52:53 | Gabi.Davar | create | |
|