Message 184570 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	r.david.murray
Recipients	Matt.Bachmann, r.david.murray, raduv
Date	2013-03-19.00:43:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1363653786.4.0.057735677562.issue17464@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch. Rather than create and destroy a directory for every test (setUp/tearDown), it is possible to use the test.support.temp_cwd context manager to create and destroy one inside the single tests that need it. A nit: we prefer to keep the line length to <80 (that is, max 79). In test_getting_all_methods_from_class, why is 'method_returning_true' not in the list? I also worry that this test is a bit fragile, but I don't have a good suggestion for how to fix that, so we'll probably just have to live with it.

Thanks for the patch.

Rather than create and destroy a directory for every test (setUp/tearDown), it is possible to use the test.support.temp_cwd context manager to create and destroy one inside the single tests that need it.

A nit: we prefer to keep the line length to <80 (that is, max 79).

In test_getting_all_methods_from_class, why is 'method_returning_true' not in the list?  I also worry that this test is a bit fragile, but I don't have a good suggestion for how to fix that, so we'll probably just have to live with it.

History
Date	User	Action	Args
2013-03-19 00:43:06	r.david.murray	set	recipients: + r.david.murray, raduv, Matt.Bachmann
2013-03-19 00:43:06	r.david.murray	set	messageid: <1363653786.4.0.057735677562.issue17464@psf.upfronthosting.co.za>
2013-03-19 00:43:06	r.david.murray	link	issue17464 messages
2013-03-19 00:43:06	r.david.murray	create