Message184503
Hi,
Here are some small comments to your otherwise good to have patch:
-- assertEquals has been deprecated in favor of assertEqual, and usually it's great to be consistent across the test suite
-- likewise maxDiff should be max_diff mainly because of consistency and because of pep8's naming styles
-- self.temp_dir is never cleaned up (on tearDown maybe?) and gettempdir() doesn't really look like a good option; maybe you wanted to create a new temporary directory rather than pointing to the filesystem's tmp dir ?
-- the patch doesn't apply cleanly, at least for me - the ACKS hunk is failing for me |
|
Date |
User |
Action |
Args |
2013-03-18 19:51:12 | raduv | set | recipients:
+ raduv, Matt.Bachmann |
2013-03-18 19:51:12 | raduv | set | messageid: <1363636272.52.0.732548381809.issue17464@psf.upfronthosting.co.za> |
2013-03-18 19:51:12 | raduv | link | issue17464 messages |
2013-03-18 19:51:12 | raduv | create | |
|