This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author raduv
Recipients Matt.Bachmann, raduv
Date 2013-03-18.19:51:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1363636272.52.0.732548381809.issue17464@psf.upfronthosting.co.za>
In-reply-to
Content
Hi,

Here are some small comments to your otherwise good to have patch:

-- assertEquals has been deprecated in favor of assertEqual, and usually it's great to be consistent across the test suite
-- likewise maxDiff should be max_diff mainly because of consistency and because of pep8's naming styles
-- self.temp_dir is never cleaned up (on tearDown maybe?) and gettempdir() doesn't really look like a good option; maybe you wanted to create a new temporary directory rather than pointing to the filesystem's tmp dir ?
-- the patch doesn't apply cleanly, at least for me - the ACKS hunk is failing for me
History
Date User Action Args
2013-03-18 19:51:12raduvsetrecipients: + raduv, Matt.Bachmann
2013-03-18 19:51:12raduvsetmessageid: <1363636272.52.0.732548381809.issue17464@psf.upfronthosting.co.za>
2013-03-18 19:51:12raduvlinkissue17464 messages
2013-03-18 19:51:12raduvcreate