This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Carlo_Bramini
Recipients Carlo_Bramini, brian.curtin, ezio.melotti, loewis, rpetrov, vstinner
Date 2013-02-24.18:17:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1361729876.44.0.281755885526.issue10560@psf.upfronthosting.co.za>
In-reply-to
Content
Hello,
no problem, the fix on GetModuleHandle() can be avoided without problems if you want. Anyways, although nowadays the "hybrid" operating systems like Windows 9x/ME are dead and burried, in this particular case I would still suggest to use directly GetModuleHandleA(), because the instance to find is just "KERNEL32" and it is not made by esoteric characters. Normally, as developer for Windows platform, I would surely agree to use the wide char version, but due to the highly portable nature of Python, with my experience I learned that some particular conditions can make the cross compiling for Windows easier, if you do not explicitely add "-fshort-wchar".
BTW, the ".dll" in the string of the parameter is redundant as you can see from MSDN page of GetModuleHandle(), there are also few other points in the sources of Python that can be "optimized", but afterall these are just "fine" improvements, not so much important if they are compared to other things...
History
Date User Action Args
2013-02-24 18:17:56Carlo_Braminisetrecipients: + Carlo_Bramini, loewis, vstinner, ezio.melotti, rpetrov, brian.curtin
2013-02-24 18:17:56Carlo_Braminisetmessageid: <1361729876.44.0.281755885526.issue10560@psf.upfronthosting.co.za>
2013-02-24 18:17:56Carlo_Braminilinkissue10560 messages
2013-02-24 18:17:56Carlo_Braminicreate