Message180746
Thanks for the review Ezio!
I've fixed the order of the arguments of assertEqual. Regarding your other comment: I agree that your code is shorter and clearer, but it doesn't do exactly the same thing. cls.__init_class__ can be None, and in that case, we should call it (the user should get a TypeError). So the getattr call would need another sentinel object. And with that sentinel, I don't think the code would be shorter and clearer any more. |
|
Date |
User |
Action |
Args |
2013-01-27 07:15:59 | daniel.urban | set | recipients:
+ daniel.urban, ncoghlan, ezio.melotti |
2013-01-27 07:15:59 | daniel.urban | set | messageid: <1359270959.18.0.604521626745.issue17044@psf.upfronthosting.co.za> |
2013-01-27 07:15:59 | daniel.urban | link | issue17044 messages |
2013-01-27 07:15:59 | daniel.urban | create | |
|