Message180697
In http://docs.python.org/dev/c-api/memory.html#examples:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
char *buf1 = PyMem_New(char, BUFSIZ);
char *buf2 = (char *) malloc(BUFSIZ);
char *buf3 = (char *) PyMem_Malloc(BUFSIZ);
...
PyMem_Del(buf3); /* Wrong -- should be PyMem_Free() */
free(buf2); /* Right -- allocated via malloc() */
free(buf1); /* Fatal -- should be PyMem_Del() */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Is there a good reason to have the second set of 3 lines in the opposite order as the first three? At first I missed that they were in a different order and thought there was an error in the example. If there's no good reason for the order, it would be worth fixing. If there is a good reason, a comment in the example would help. Either way I'd be glad to patch it (will go ahead with fixing the ordering later today if no one does it first). |
|
Date |
User |
Action |
Args |
2013-01-26 18:20:38 | eric.snow | set | recipients:
+ eric.snow, docs@python |
2013-01-26 18:20:37 | eric.snow | set | messageid: <1359224437.99.0.267409459887.issue17042@psf.upfronthosting.co.za> |
2013-01-26 18:20:37 | eric.snow | link | issue17042 messages |
2013-01-26 18:20:37 | eric.snow | create | |
|