This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author skrah
Recipients christian.heimes, dmalcolm, doko, lemburg, loewis, meador.inge, pitrou, skrah
Date 2012-12-21.20:50:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <20121221205009.GA21137@sleipnir.bytereef.org>
In-reply-to <1356119509.53.0.400862819802.issue16745@psf.upfronthosting.co.za>
Content
Meador Inge <report@bugs.python.org> wrote:
> Personally I prefer using attributes instead of pragmas.  The GCC manual recommends such as well.

I followed www.akkadia.org/drepper/dsohowto.pdf . Drepper seems to be fine
with the use of pragmas in internal headers.

> There are also other sources in Modules/* that use '__attribute__ ((visibility ("hidden")))'.  Namely ctypes and zlib.

They do, but for a tiny amount of functions. mpdecimal.h, which is internal
as far as _decimal.so is concerned, also needs to be changed. There you have
something like 200 lines of

[...]
void mpd_qrescale(mpd_t *result, const mpd_t *a, mpd_ssize_t exp, const mpd_context_t *ctx, uint32_t *status) Py_HIDDEN;
void mpd_qrescale_fmt(mpd_t *result, const mpd_t *a, mpd_ssize_t exp, const mpd_context_t *ctx, uint32_t *status) Py_HIDDEN;
[...],

which increases the size of the diff between the standalone libmpdec and the
one shipped with Python.
History
Date User Action Args
2012-12-21 20:50:07skrahsetrecipients: + skrah, lemburg, loewis, doko, pitrou, christian.heimes, dmalcolm, meador.inge
2012-12-21 20:50:07skrahlinkissue16745 messages
2012-12-21 20:50:06skrahcreate