Message 173811 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	Mark.Gius, gregory.p.smith, jcea, neologix
Date	2012-10-26.00:19:12
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1351210753.96.0.179760136392.issue16327@psf.upfronthosting.co.za>
In-reply-to

Content
python 3 already catches all exceptions and handles closing of p2cwrite, c2pread and errread here. i don't know which branch this patch is against. Regardless, it makes sense that the other fd's, if created by us, also need to be cleaned up. The code also needs to ignore exceptions from the close() call. http://hg.python.org/cpython/file/cbdd6852a274/Lib/subprocess.py#l811

python 3 already catches all exceptions and handles closing of p2cwrite, c2pread and errread here.  i don't know which branch this patch is against.  Regardless, it makes sense that the other fd's, if created by us, also need to be cleaned up.  The code also needs to ignore exceptions from the close() call.

 http://hg.python.org/cpython/file/cbdd6852a274/Lib/subprocess.py#l811

History
Date	User	Action	Args
2012-10-26 00:19:14	gregory.p.smith	set	recipients: + gregory.p.smith, jcea, neologix, Mark.Gius
2012-10-26 00:19:13	gregory.p.smith	set	messageid: <1351210753.96.0.179760136392.issue16327@psf.upfronthosting.co.za>
2012-10-26 00:19:13	gregory.p.smith	link	issue16327 messages
2012-10-26 00:19:12	gregory.p.smith	create