Message168207
Currently Popen.communicate accept str is universal_newlines==True and bytes if universal_newlines==False.
I like to accept both str and bytes if universal_newlines is False and raise explicit exception for bytes if universal_newlines is True.
Looks like universal_newlines for bytes doesn't make sense, also we prefer to use str everywhere. Bytes should be used if it is really byte-stream or if unicode cannot be passed by some limitations of underlying OS etc.
There are couple dark corners:
1. What to do if stdin doesn't have `encoding` attribute? Convert to bytes using filesystemencoding? Raise explicit exception? Adding `encode` parameter for .communicate doesn't looks elegant.
2. How .communicate works on Windows? I see completely different implementation of this method for win32. |
|
Date |
User |
Action |
Args |
2012-08-14 15:47:01 | asvetlov | set | recipients:
+ asvetlov |
2012-08-14 15:47:01 | asvetlov | set | messageid: <1344959221.38.0.0409924242397.issue15649@psf.upfronthosting.co.za> |
2012-08-14 15:47:00 | asvetlov | link | issue15649 messages |
2012-08-14 15:47:00 | asvetlov | create | |
|