Message167983
It seems like these tests can be made more DRY. For example, the line `args = popen.cmd_line` appears in every test. You could make an assert_args() helper method to address this. There also seems to be a lot of overlap between tests for each browser. A DRY approach would let one see more easily how the tests differ across browsers.
Do you also need to include the test boilerplate at the bottom? See, for example--
http://hg.python.org/cpython/file/867de88b69f0/Lib/test/test_textwrap.py#l732 |
|
Date |
User |
Action |
Args |
2012-08-11 17:43:49 | chris.jerdonek | set | recipients:
+ chris.jerdonek, georg.brandl, r.david.murray, anton.barkovsky |
2012-08-11 17:43:49 | chris.jerdonek | set | messageid: <1344707029.77.0.498607167937.issue15557@psf.upfronthosting.co.za> |
2012-08-11 17:43:49 | chris.jerdonek | link | issue15557 messages |
2012-08-11 17:43:48 | chris.jerdonek | create | |
|