Message166800
Le dimanche 29 juillet 2012 à 17:45 +0000, Meador Inge a écrit :
> Anyway, the way you are implementing the tests has the same issue as Martin pointed
> out for the 'object.__sizeof__' method in issue15402. I could replace the
> 'buffered_sizeof' implementation with:
>
> static PyObject *
> buffered_sizeof(buffered *self, void *unused)
> {
> Py_ssize_t res;
>
> res = 1;
> if (self->buffer)
> res += self->buffer_size;
> return PyLong_FromSsize_t(res);
> }
>
> and the tests will still pass.
That's true but, OTOH, I don't think it's very important. First, because
it is a rather unlikely mistake. Second, because the important thing is
to check that the internal buffer is part of the returned size, which is
what Serhiy's test checks for. |
|
Date |
User |
Action |
Args |
2012-07-29 17:55:10 | pitrou | set | recipients:
+ pitrou, loewis, benjamin.peterson, stutzbach, meador.inge, python-dev, hynek, serhiy.storchaka |
2012-07-29 17:55:09 | pitrou | link | issue15487 messages |
2012-07-29 17:55:09 | pitrou | create | |
|