Message166664
On Sat, Jul 28, 2012 at 3:27 AM, Serhiy Storchaka
<report@bugs.python.org> wrote:
> Serhiy Storchaka <storchaka@gmail.com> added the comment:
>
>> issue15456
>> efficiently demonstrates that the current style can detect bugs
>> which testing with object.__sizeof__ can't.
>
> Hmm, I see this as a counterexample. The bug *was not detected* with the
> current style of testing.
I disagree. It wasn't *directly* detected -- the test broke because of the new
structure field that was added and not because of the new dynamic memory
allocation that was added. Even so, the fact that the test broke *at all*
should have thrown a warning flag up in the developer's mind to reevaluate
how the size is calculated. If the test were written using your
object.__sizeof__
method, then the test would not have broken *at all* and therefore it might not
have even crossed the developers mind to verify whether the sizeof calculation
is correct. |
|
Date |
User |
Action |
Args |
2012-07-28 16:35:19 | meador.inge | set | recipients:
+ meador.inge, loewis, gregory.p.smith, jcea, mark.dickinson, asvetlov, skrah, serhiy.storchaka |
2012-07-28 16:35:18 | meador.inge | link | issue15402 messages |
2012-07-28 16:35:18 | meador.inge | create | |
|