This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author hynek
Recipients hynek, ocean-city, pitrou
Date 2012-05-29.13:41:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1338298880.03.0.243913454842.issue10053@psf.upfronthosting.co.za>
In-reply-to
Content
I think this issue is still valid. However, I’d favor the attached (simpler) patch that keeps track whether self->fd is our own (i.e. a result of an open() operation) or from outside.

A couple of notes:

 - I'm not sure why your test skipped if the Exception wasn't raised, I'd say that's a valid test fail.
 - The fd has been closed explicitly when seeking for append mode failed, so I removed it.
 - I'm not convinced it's worth/sensible to be back ported as it's a change in behavior.

Tests succeed on OS X & Linux.

Opinions? Win32 tests results?
History
Date User Action Args
2012-05-29 13:41:20hyneksetrecipients: + hynek, pitrou, ocean-city
2012-05-29 13:41:20hyneksetmessageid: <1338298880.03.0.243913454842.issue10053@psf.upfronthosting.co.za>
2012-05-29 13:41:19hyneklinkissue10053 messages
2012-05-29 13:41:19hynekcreate