This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author v+python
Recipients orsenthil, quentel, v+python
Date 2012-05-07.21:15:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336425336.27.0.546029481239.issue14565@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Pierre,

You are right, the "found" variable is not needed, I guess the reason I coded it that way, is I had some validation code before the return, during testing, so it was easier not to have it in three places.

Regarding precalculating ln, I don't know how Python is coded internally, so it seems that string compares could be lengthier integer compares, and even in your code the length is calculated sometimes.  So it is mostly an order of operations optimization... I didn't attempt to benchmark it with various URL and cgi_directories values, including at least both some with large prefix matches, and some without... I didn't figure it would matter much, but if you think it does, then feel free to benchmark.
History
Date User Action Args
2012-05-07 21:15:36v+pythonsetrecipients: + v+python, orsenthil, quentel
2012-05-07 21:15:36v+pythonsetmessageid: <1336425336.27.0.546029481239.issue14565@psf.upfronthosting.co.za>
2012-05-07 21:15:35v+pythonlinkissue14565 messages
2012-05-07 21:15:35v+pythoncreate