Message156758
Some style comments:
- don't use "except: self.fail()", just let the exception pass through
- when monkeypatching hmac.new, use a try...finally block so that the mock doesn't stay in place if the test fails for whatever reason
- it's a bit of a nit, but when using "with warnings.catch_warnings", I would put the asserts on the context manager result outside of the "with" block
- I get a warning in test_noncallable_digestmod, it would be nice to silence it:
/home/antoine/cpython/default/Lib/test/test_hmac.py:254: RuntimeWarning: No block_size attribute on given digest object; Assuming 64.
h = hmac.HMAC(b"key", b"", hmac) |
|
Date |
User |
Action |
Args |
2012-03-25 15:17:45 | pitrou | set | recipients:
+ pitrou, gregory.p.smith, eric.araujo, packetslave |
2012-03-25 15:17:45 | pitrou | set | messageid: <1332688665.1.0.552526119889.issue14322@psf.upfronthosting.co.za> |
2012-03-25 15:17:44 | pitrou | link | issue14322 messages |
2012-03-25 15:17:44 | pitrou | create | |
|