This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients eric.smith, jcea, mark.dickinson, python-dev, samuel.iseli, skrah
Date 2012-03-10.16:41:26
SpamBayes Score 1.2260204e-08
Marked as misclassified No
Message-id <1331397687.79.0.424983174623.issue13889@psf.upfronthosting.co.za>
In-reply-to
Content
Patch looks fine to me.  A couple of minor points (which I'm happy to fix at commit time if you agree, and don't want to create a new patch):

- it looks to me as though the #ifdef _WIN32 isn't necessary any more;  it's enough that we're on MSVC and that this isn't a 64-bit build.

- I'd suggest replacing _PC_53 with _PC_53 | _RC_NEAR.  I know it's technically redundant, since _RC_NEAR happens to be 0, but it makes the intent of the code clearer.

I'd still want to see all the tests pass on both x64 and x86 Windows before applying this;  I may have an opportunity to test this on x64 in the near future.
History
Date User Action Args
2012-03-10 16:41:27mark.dickinsonsetrecipients: + mark.dickinson, jcea, eric.smith, skrah, python-dev, samuel.iseli
2012-03-10 16:41:27mark.dickinsonsetmessageid: <1331397687.79.0.424983174623.issue13889@psf.upfronthosting.co.za>
2012-03-10 16:41:27mark.dickinsonlinkissue13889 messages
2012-03-10 16:41:26mark.dickinsoncreate