This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eli.bendersky
Recipients effbot, eli.bendersky, ezio.melotti, flox, scoder
Date 2012-03-06.04:53:07
SpamBayes Score 5.166444e-07
Marked as misclassified No
Message-id <1331009590.86.0.19034471797.issue14178@psf.upfronthosting.co.za>
In-reply-to
Content
Attaching a patch that fixes the slice deletion problems.

The approach I've taken is follow a similar implementation in Objects/listobject.c; when a slice is deleted, it can be done efficiently by using memmove to shift whole blocks of leftover children.

Also added a new test class to test_xml_etree specifically to test slicing with Element objects and deleting slices with strange steps.

I'll leave it up for review for a couple of days before committing.
History
Date User Action Args
2012-03-06 04:53:11eli.benderskysetrecipients: + eli.bendersky, effbot, scoder, ezio.melotti, flox
2012-03-06 04:53:10eli.benderskysetmessageid: <1331009590.86.0.19034471797.issue14178@psf.upfronthosting.co.za>
2012-03-06 04:53:10eli.benderskylinkissue14178 messages
2012-03-06 04:53:09eli.benderskycreate