➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients benjamin.peterson, brett.cannon, pitrou, vstinner
Date 2012-02-29.15:19:26
SpamBayes Score 1.2333709e-06
Marked as misclassified No
Message-id <1330528767.26.0.403915015073.issue14153@psf.upfronthosting.co.za>
In-reply-to
Content 
I don't seen any refcounting problem here, but your patch is buggy.
Before patch:

>>> os.device_encoding(0)
'UTF-8'

After patch:

>>> os.device_encoding(0) is None
True

Interestingly, it seems there is no test for os.device_encoding. Perhaps add one to test_os?
History
Date User Action Args
2012-02-29 15:19:27pitrousetrecipients: + pitrou, brett.cannon, vstinner, benjamin.peterson
2012-02-29 15:19:27pitrousetmessageid: <1330528767.26.0.403915015073.issue14153@psf.upfronthosting.co.za>
2012-02-29 15:19:26pitroulinkissue14153 messages
2012-02-29 15:19:26pitroucreate