This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author meador.inge
Recipients meador.inge, pitrou, sbt, vstinner
Date 2012-02-24.15:59:10
SpamBayes Score 1.65493e-09
Marked as misclassified No
Message-id <1330099151.98.0.40027983947.issue14095@psf.upfronthosting.co.za>
In-reply-to
Content
The change in error handling makes this a bit harder to review, but it otherwise looks OK if this is the intended behavior.  I am not sure that it is.

The original version:

   1. If __qualname__ was present in the original dictionary,
      then it was deleted.
   2. If __qualname__ was present in the original dictionary,
      then the qualname slot in the new type was left unitialized.

Why (1) was done I don't know.  (2) is obviously a bug.

The patched version:

   1. Sets the slot qualname to the __qualname__ from the original
      dictionary (if present).
   2. Copies the __qualname__ attribute from the original dictionary
      to the new dictionary (if present).
   3. Leaves the original dictionary alone.

The deletion and unitiliazed slot problems are gone, but I am not sure if (2) is needed.  Just fixing (1) and (3) seems more reasonable to me.
History
Date User Action Args
2012-02-24 15:59:12meador.ingesetrecipients: + meador.inge, pitrou, vstinner, sbt
2012-02-24 15:59:11meador.ingesetmessageid: <1330099151.98.0.40027983947.issue14095@psf.upfronthosting.co.za>
2012-02-24 15:59:11meador.ingelinkissue14095 messages
2012-02-24 15:59:10meador.ingecreate