Message154140
The change in error handling makes this a bit harder to review, but it otherwise looks OK if this is the intended behavior. I am not sure that it is.
The original version:
1. If __qualname__ was present in the original dictionary,
then it was deleted.
2. If __qualname__ was present in the original dictionary,
then the qualname slot in the new type was left unitialized.
Why (1) was done I don't know. (2) is obviously a bug.
The patched version:
1. Sets the slot qualname to the __qualname__ from the original
dictionary (if present).
2. Copies the __qualname__ attribute from the original dictionary
to the new dictionary (if present).
3. Leaves the original dictionary alone.
The deletion and unitiliazed slot problems are gone, but I am not sure if (2) is needed. Just fixing (1) and (3) seems more reasonable to me. |
|
Date |
User |
Action |
Args |
2012-02-24 15:59:12 | meador.inge | set | recipients:
+ meador.inge, pitrou, vstinner, sbt |
2012-02-24 15:59:11 | meador.inge | set | messageid: <1330099151.98.0.40027983947.issue14095@psf.upfronthosting.co.za> |
2012-02-24 15:59:11 | meador.inge | link | issue14095 messages |
2012-02-24 15:59:10 | meador.inge | create | |
|