Message154119
Thanks for testing and confirming that this code never worked. I am now confident that we’re about to fix once and for all this basket of bugs in the correct way.
I updated the tests to make them hopefully pass on Windows, and while doing that I realized that I don’t like the unnecessary escaping of / on posix systems. Regexes already look like grit on my monitor, so I prefer not making them harder to read. My latest patch only escapes if os.sep is the backslash.
Should apply cleanly to 2.7, please test.
> While we're talking about translate_pattern(), I have a question about this line:
> [snip]
> For example, it seems wrong that "recursive-include foo bar.*" matches foo/test_bar.py.
Certainly. Feel free to open another report for that, or I’ll do it. |
|
Date |
User |
Action |
Args |
2012-02-24 07:22:28 | eric.araujo | set | recipients:
+ eric.araujo, jaraco, cjw296, nadeem.vawda, tarek, Adam.Groszer |
2012-02-24 07:22:28 | eric.araujo | set | messageid: <1330068148.54.0.419872128605.issue6884@psf.upfronthosting.co.za> |
2012-02-24 07:22:27 | eric.araujo | link | issue6884 messages |
2012-02-24 07:22:27 | eric.araujo | create | |
|