Message 152266 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	orsenthil
Recipients	Nathanael.Noblet, loewis, orsenthil, pitrou
Date	2012-01-29.22:16:24
SpamBayes Score	0.0006597576
Marked as misclassified	No
Message-id	<1327875386.21.0.543656005968.issue13856@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for submitting the patch. Couple of comments. 1. This is a new feature, so the patch should be addressed against 3.x. 2. The patch lacks tests and documentation and hence it is not complete. You could take a look at http/client.py or ssl.py (with test_ssl.py) for for passing the key and cert from the client. Antoine - I fail to recollect, but is there any reason for the clients in the stdlib are not carrying a ca_file and doing a certificate validation of the server connection? Is it required (or a good idea) ?

Thanks for submitting the patch. Couple of comments.

1. This is a new feature, so the patch should be addressed against 3.x. 
2. The patch lacks tests and documentation and hence it is not complete.

You could take a look at http/client.py or ssl.py (with test_ssl.py) for for passing the key and cert from the client.

Antoine - I fail to recollect, but is there any reason for the clients in the stdlib are not carrying a ca_file and doing a certificate validation of the server connection? Is it required (or a good idea) ?

History
Date	User	Action	Args
2012-01-29 22:16:26	orsenthil	set	recipients: + orsenthil, loewis, pitrou, Nathanael.Noblet
2012-01-29 22:16:26	orsenthil	set	messageid: <1327875386.21.0.543656005968.issue13856@psf.upfronthosting.co.za>
2012-01-29 22:16:25	orsenthil	link	issue13856 messages
2012-01-29 22:16:25	orsenthil	create