Message150507
test_string.diff looks good, except that it should probably only test the exception type, not the message (they are not a guaranteed part of the Python language and may change arbitrarily between versions or implementations (e.g. PyPy), so better not to add tests that depend on exact words).
I don’t have anything specific to say about issue13598.diff; if it makes the test pass, then it’s good. “if manual == True” should just be replaced by “if manual”.
If you’d like to, you can make one patch with fix + tests that addresses my comments and remove the older diffs. |
|
Date |
User |
Action |
Args |
2012-01-03 16:16:06 | eric.araujo | set | recipients:
+ eric.araujo, terry.reedy, eric.smith, meador.inge, Ramchandra Apte |
2012-01-03 16:16:06 | eric.araujo | set | messageid: <1325607366.24.0.350565206807.issue13598@psf.upfronthosting.co.za> |
2012-01-03 16:16:05 | eric.araujo | link | issue13598 messages |
2012-01-03 16:16:05 | eric.araujo | create | |
|