Message148998
I am a little puzzled by the patch. In logic, 'A and B' is equivalent to 'not A or not B'. But in the patch,
- if (_Py_stat(filename, &statbuf) == 0 && /it exists */
- S_ISDIR(statbuf.st_mode)) /* it's a directory */
+ if (_Py_stat(filename, &statbuf) != 0 || S_ISDIR(statbuf.st_mode))
you seem to change to 'not A or B', without negating B. Is this intentional? What am I missing? Some subtle effect of lazy evaluation? Or an intentional change in the logic? |
|
Date |
User |
Action |
Args |
2011-12-07 22:20:28 | terry.reedy | set | recipients:
+ terry.reedy, loewis, barry, georg.brandl, rhettinger, pitrou, eric.smith, giampaolo.rodola, nadeem.vawda, Arfrever, neologix, python-dev, eric.snow |
2011-12-07 22:20:28 | terry.reedy | set | messageid: <1323296428.65.0.948149726765.issue11051@psf.upfronthosting.co.za> |
2011-12-07 22:20:28 | terry.reedy | link | issue11051 messages |
2011-12-07 22:20:27 | terry.reedy | create | |
|