Message148722
Hi Berker Peksag, thanks for your interest in contributing. Your patch is not what I had in mind: In test_command_sdist, a test should create an sdist and check that it fails with an error message, not instantiate a version object. Distutils2 has many layers; at the base, version needs to reject an incorrect version with a Python exception (and we should test that in test_version), at the top, commands like check, sdist and bdist should catch that exception and display a user-friendly error message (and their tests should create Python files and run the command). Does this help? |
|
Date |
User |
Action |
Args |
2011-12-01 14:00:54 | eric.araujo | set | recipients:
+ eric.araujo, tarek, SilentGhost, swamiyeswanth, gotcha, berker.peksag |
2011-12-01 14:00:53 | eric.araujo | set | messageid: <1322748053.81.0.71043868929.issue11060@psf.upfronthosting.co.za> |
2011-12-01 14:00:53 | eric.araujo | link | issue11060 messages |
2011-12-01 14:00:53 | eric.araujo | create | |
|