Message146647
Here is my quick review:
- shouldn't the opener also get the third open() argument (although it currently seems to always be 0o666)?
- when fdobj is NULL, you shouldn't override the original error
- PyLong_AsLong can fail (if the opener returns too large an int), you should check for that
Thank you! |
|
Date |
User |
Action |
Args |
2011-10-30 17:30:40 | pitrou | set | recipients:
+ pitrou, terry.reedy, amaury.forgeotdarc, vstinner, nadeem.vawda, ned.deily, eric.araujo, Arfrever, neologix, rosslagerwall |
2011-10-30 17:30:40 | pitrou | set | messageid: <1319995840.62.0.0509665537284.issue12797@psf.upfronthosting.co.za> |
2011-10-30 17:30:39 | pitrou | link | issue12797 messages |
2011-10-30 17:30:39 | pitrou | create | |
|