This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients pitrou, vstinner
Date 2011-10-11.23:42:17
SpamBayes Score 0.00073007727
Marked as misclassified No
Message-id <1318376538.12.0.399479516824.issue13155@psf.upfronthosting.co.za>
In-reply-to
Content
find_max_char() returns 0x10000 instead of 0x10FFFF, which may be wrong (or at least, surprising). You may add a max_char variable using other macros like MAX_CHAR_ASCII, MAX_CHAR_UCS1, ..., which will be set at the same time than mask. Or restore your if (ret >= 0x10000) return 0x10ffff; else return ret;.

Constants look inconsistent:

+    const STRINGLIB_CHAR *unrolled_end = begin + (n & ~ (Py_ssize_t) 7);
+        p += 4;

You may use STRINGLIB_CHAR in:

+        Py_UCS4 bits = p[0] | p[1] | p[2] | p[3];
History
Date User Action Args
2011-10-11 23:42:18vstinnersetrecipients: + vstinner, pitrou
2011-10-11 23:42:18vstinnersetmessageid: <1318376538.12.0.399479516824.issue13155@psf.upfronthosting.co.za>
2011-10-11 23:42:17vstinnerlinkissue13155 messages
2011-10-11 23:42:17vstinnercreate