This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients amaury.forgeotdarc, neologix, pitrou, vsemionov
Date 2011-10-04.10:42:13
SpamBayes Score 5.7070647e-08
Marked as misclassified No
Message-id <1317724722.3784.2.camel@localhost.localdomain>
In-reply-to <1317491223.79.0.275640510789.issue13070@psf.upfronthosting.co.za>
Content
> > Also, is it ok to just return NULL or should the error state also be
> > set?
> 
> Well, I'm not sure, that why I made you and Amaury noisy :-)
> AFAICT, this is the only case where _check_closed can encounter a NULL
> self->writer.

Probably. OTOH, not setting the error state when returning NULL is
usually an error (and can result in difficult-to-debug problems), so
let's stay on the safe side.

> Furthermore, I'm not sure about what kind of error would make sense here.

RuntimeError perhaps.
History
Date User Action Args
2011-10-04 10:42:14pitrousetrecipients: + pitrou, amaury.forgeotdarc, neologix, vsemionov
2011-10-04 10:42:13pitroulinkissue13070 messages
2011-10-04 10:42:13pitroucreate