Message144872
> > Also, is it ok to just return NULL or should the error state also be
> > set?
>
> Well, I'm not sure, that why I made you and Amaury noisy :-)
> AFAICT, this is the only case where _check_closed can encounter a NULL
> self->writer.
Probably. OTOH, not setting the error state when returning NULL is
usually an error (and can result in difficult-to-debug problems), so
let's stay on the safe side.
> Furthermore, I'm not sure about what kind of error would make sense here.
RuntimeError perhaps. |
|
Date |
User |
Action |
Args |
2011-10-04 10:42:14 | pitrou | set | recipients:
+ pitrou, amaury.forgeotdarc, neologix, vsemionov |
2011-10-04 10:42:13 | pitrou | link | issue13070 messages |
2011-10-04 10:42:13 | pitrou | create | |
|