Message144824
Hello,
method:: socket.getsockopt(level, optname[, optarg])
The overloading of the third parameter is confusing: it can already be an integer value or a buffer size, I don't think that adding a third possibility is a good idea. It might be better to add another optional `buffer` argument (and ignore `buflen` if this argument is provided).
Also, it would be nice to have a corresponding unit test: since I doubt this buffer argument is supported by many Unices out there, you can probably reuse a subset of what ipset does (just take care and guard it by @support.requires_linux_version() if applicable). |
|
Date |
User |
Action |
Args |
2011-10-03 17:04:47 | neologix | set | recipients:
+ neologix, pitrou, python-dev, ximaera |
2011-10-03 17:04:47 | neologix | set | messageid: <1317661487.13.0.16150929828.issue13045@psf.upfronthosting.co.za> |
2011-10-03 17:04:46 | neologix | link | issue13045 messages |
2011-10-03 17:04:46 | neologix | create | |
|