Message141527
Éric, I think your points are good ones. (And, as I return to this patch after three months, I should thank the PSF for sponsoring the CPython sprint here at PyOhio, and creating this opportunity for me to continue trying to land this patch!) I am attaching a fourth version of the patch. It incorporates your two suggestions, Éric. It also applies cleanly once against today's trunk; besides the usual line number changes as code has come and gone, I am happy to see that my change of an "assertTrue" for an "assertIs" in the test suite has already taken place thanks to another patch in the meantime. |
|
Date |
User |
Action |
Args |
2011-08-01 18:49:15 | brandon-rhodes | set | recipients:
+ brandon-rhodes, ncoghlan, belopolsky, pitrou, benjamin.peterson, eric.araujo, daniel.urban |
2011-08-01 18:49:14 | brandon-rhodes | set | messageid: <1312224554.76.0.823309846915.issue11572@psf.upfronthosting.co.za> |
2011-08-01 18:49:14 | brandon-rhodes | link | issue11572 messages |
2011-08-01 18:49:14 | brandon-rhodes | create | |
|