This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author joshtriplett
Recipients eric.araujo, joshtriplett, ncoghlan, ron_adam, vstinner
Date 2011-07-23.01:09:48
SpamBayes Score 1.6133872e-11
Marked as misclassified No
Message-id <1311383390.53.0.206919730228.issue12603@psf.upfronthosting.co.za>
In-reply-to
Content
The current behavior of pydoc will cause synopsis to always incorrectly return "None" as the synopsis for any module with mtime == 0.  Both of the proposed fixes will fix that bug without affecting any case where mtime != 0, so I don't think either one has backward-compatibility issues.

I'd suggest using the fix of changing the .get call to return a default of (None, None) and changing the conditional to "lastupdate is not None and lastupdate < mtime".  That variant seems like more obvious code (since None clearly means "no lastupdate time"), and it avoids special-casing an mtime of 0 and bypassing the synopsis cache.

I don't mind writing a patch if that would help this fix get in.  I'll try to write onein the near future, but I certainly won't mind if someone else beats me to it. :)
History
Date User Action Args
2011-07-23 01:09:50joshtriplettsetrecipients: + joshtriplett, ncoghlan, vstinner, ron_adam, eric.araujo
2011-07-23 01:09:50joshtriplettsetmessageid: <1311383390.53.0.206919730228.issue12603@psf.upfronthosting.co.za>
2011-07-23 01:09:49joshtriplettlinkissue12603 messages
2011-07-23 01:09:48joshtriplettcreate