Message140647
You're very kind David.
Hope I can contribute with something more relevant next time :)
best regards,
Felipe
2011/7/18 R. David Murray <report@bugs.python.org>
>
> R. David Murray <rdmurray@bitdance.com> added the comment:
>
> Thank you both for your work on this. The patch I committed is a
> combination of my _addr_only, Filipe's tests, and Catalin's modifications to
> those tests. quoteaddr, although in the __all__, is not documented and is
> really an implementation detail, as is the new _addr_only. So I am only
> testing them indirectly through the documented parts of the API (I added a
> test for <> address, and one for an IDNA encoded address).
>
> Catalin, I think you are correct about the try/except/None stuff. As far
> as I can tell it is left over from the old days before the email package and
> its philosophy of never throwing parsing errors. Nowadays if parseaddr
> throws an error, it is a bug. That's a refactoring not a bug fix, though,
> so I didn't backport it.
>
> ----------
> resolution: -> fixed
> stage: test needed -> committed/rejected
> status: open -> closed
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue7484>
> _______________________________________
> |
File name |
Uploaded |
unnamed
|
felipecruz,
2011-07-19.02:17:09
|
|
Date |
User |
Action |
Args |
2011-07-19 02:17:10 | felipecruz | set | recipients:
+ felipecruz, r.david.murray, pablomouzo, mpg, catalin.iacob, python-dev |
2011-07-19 02:17:09 | felipecruz | link | issue7484 messages |
2011-07-19 02:17:09 | felipecruz | create | |
|