This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author felipecruz
Recipients catalin.iacob, felipecruz, mpg, pablomouzo, python-dev, r.david.murray
Date 2011-07-19.02:17:09
SpamBayes Score 8.757357e-10
Marked as misclassified No
Message-id <CAEynwxsg=joBy4hrW3CY+APONROh=fnELSR9Oon=9Vrq7yO=8w@mail.gmail.com>
In-reply-to <1311041395.51.0.38301259116.issue7484@psf.upfronthosting.co.za>
Content
You're very kind David.

Hope I can contribute with something more relevant next time :)

best regards,
Felipe

2011/7/18 R. David Murray <report@bugs.python.org>

>
> R. David Murray <rdmurray@bitdance.com> added the comment:
>
> Thank you both for your work on this.  The patch I committed is a
> combination of my _addr_only, Filipe's tests, and Catalin's modifications to
> those tests.  quoteaddr, although in the __all__, is not documented and is
> really an implementation detail, as is the new _addr_only.  So I am only
> testing them indirectly through the documented parts of the API (I added a
> test for <> address, and one for an IDNA encoded address).
>
> Catalin, I think you are correct about the try/except/None stuff.  As far
> as I can tell it is left over from the old days before the email package and
> its philosophy of never throwing parsing errors.  Nowadays if parseaddr
> throws an error, it is a bug.  That's a refactoring not a bug fix, though,
> so I didn't backport it.
>
> ----------
> resolution:  -> fixed
> stage: test needed -> committed/rejected
> status: open -> closed
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue7484>
> _______________________________________
>
Files
File name Uploaded
unnamed felipecruz, 2011-07-19.02:17:09
History
Date User Action Args
2011-07-19 02:17:10felipecruzsetrecipients: + felipecruz, r.david.murray, pablomouzo, mpg, catalin.iacob, python-dev
2011-07-19 02:17:09felipecruzlinkissue7484 messages
2011-07-19 02:17:09felipecruzcreate