This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients catalin.iacob, felipecruz, mpg, pablomouzo, python-dev, r.david.murray
Date 2011-07-19.02:09:54
SpamBayes Score 3.2982157e-07
Marked as misclassified No
Message-id <1311041395.51.0.38301259116.issue7484@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you both for your work on this.  The patch I committed is a combination of my _addr_only, Filipe's tests, and Catalin's modifications to those tests.  quoteaddr, although in the __all__, is not documented and is really an implementation detail, as is the new _addr_only.  So I am only testing them indirectly through the documented parts of the API (I added a test for <> address, and one for an IDNA encoded address).

Catalin, I think you are correct about the try/except/None stuff.  As far as I can tell it is left over from the old days before the email package and its philosophy of never throwing parsing errors.  Nowadays if parseaddr throws an error, it is a bug.  That's a refactoring not a bug fix, though, so I didn't backport it.
History
Date User Action Args
2011-07-19 02:09:55r.david.murraysetrecipients: + r.david.murray, pablomouzo, mpg, catalin.iacob, python-dev, felipecruz
2011-07-19 02:09:55r.david.murraysetmessageid: <1311041395.51.0.38301259116.issue7484@psf.upfronthosting.co.za>
2011-07-19 02:09:54r.david.murraylinkissue7484 messages
2011-07-19 02:09:54r.david.murraycreate