Message140125
> See also three comments about style on http://bugs.python.org/review/8668/diff2/2845:3011/7845
I'm not sure I follow? The patch I attached does not violate the style guidelines that you indicate in the comments. The only failing I see is that get_reinitialized_command inside cmd.py does not have a doc string. I was following the path of minimal change, but I will be happy to add one.
Unless I am misunderstanding something about the other style comments I will work up another version with subcommand kwargs, docstring, and tests.
Thanks again Éric |
|
Date |
User |
Action |
Args |
2011-07-11 14:12:10 | thomas.holmes | set | recipients:
+ thomas.holmes, tarek, eric.araujo, alexis, higery |
2011-07-11 14:12:10 | thomas.holmes | set | messageid: <1310393530.56.0.655680180217.issue12344@psf.upfronthosting.co.za> |
2011-07-11 14:12:10 | thomas.holmes | link | issue12344 messages |
2011-07-11 14:12:09 | thomas.holmes | create | |
|