This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients alexis, eric.araujo, higery, tarek, thomas.holmes
Date 2011-07-11.13:12:56
SpamBayes Score 5.9574604e-06
Marked as misclassified No
Message-id <1310389977.7.0.363778545339.issue12344@psf.upfronthosting.co.za>
In-reply-to
Content
> In Distributions.get_reinitialized_command should the
> reinitialization of the subcommands also get passed the kwargs?
Yes, the kwargs need to be passed all the way.

> Unfortunately my understanding of the (sub)command flow is not rock
> solid.
Some methods on the command classes are just convenience wrappers for methods on the distribution object.  That’s why I propose here that the real work is done in Distribution.get_reinitialized_command, and that Command.get_reinitialized_command just delegates.

> What are your thoughts on an effective test for this?
Create a command obj with some options.  Call get_reinitialized_command.  Check that its options have the default values, not the values set on the first command obj.

Do the same thing a second time, this time with some kwargs.  Check they’re set on the resulting command obj.

See also three comments about style on http://bugs.python.org/review/8668/diff2/2845:3011/7845
History
Date User Action Args
2011-07-11 13:12:57eric.araujosetrecipients: + eric.araujo, tarek, thomas.holmes, alexis, higery
2011-07-11 13:12:57eric.araujosetmessageid: <1310389977.7.0.363778545339.issue12344@psf.upfronthosting.co.za>
2011-07-11 13:12:57eric.araujolinkissue12344 messages
2011-07-11 13:12:56eric.araujocreate