➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients amaury.forgeotdarc, neologix, pitrou, vstinner
Date 2011-06-10.21:57:27
SpamBayes Score 0.0024612728
Marked as misclassified No
Message-id <1307743047.69.0.962138675116.issue12287@psf.upfronthosting.co.za>
In-reply-to
Content 
Comments on is_selectable.diff.

> +#define IS_SELECTABLE(s) (_PyIsSelectable_fd((s)->sock_fd) || s->sock_timeout <= 0.0)

You may add parenthesis around the second s (even if it's unrelated to this issue and not a regression of your patch).

> +#ifdef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE
> ...
>  #if defined(_MSC_VER)
>          max = 0;                 /* not used for Win32 */

I still don't understand these checks: why not testing simply for #ifdef MS_WINDOWS? MinGW or Cygwin have another implementation of select() which is more limited?
History
Date User Action Args
2011-06-10 21:57:27vstinnersetrecipients: + vstinner, amaury.forgeotdarc, pitrou, neologix
2011-06-10 21:57:27vstinnersetmessageid: <1307743047.69.0.962138675116.issue12287@psf.upfronthosting.co.za>
2011-06-10 21:57:27vstinnerlinkissue12287 messages
2011-06-10 21:57:27vstinnercreate