Message133696
> OK, so when I went to apply this, I figured out that the patch isn't quite right. I've redone the doc updates, and am attaching a version of the patch containing them.
>
> The issue is that the place that the IDNA decode support needs to be added isn't in parseaddr, it's in _parseaddr.py's AddresslistClass. Tests are then needed to make sure that the IDNA decoding gets done both when parseaddr and getaddresslist are used.
>
> Do you want to tackle this, Torsten?
I would like to, but I probably will not get to it before Monday. So
if anybody wants to work on this before that time, please feel free to
fix it properly. :)
Just two questions for the implementation:
1. Would it be fine to move the helper _encode_decode_addr() into
_parseaddr.py and then import it in util.py, so it can be shared
between the two?
2. Would line 232 in _parseaddr.py (AddrlistClass.getaddrlist) be a
good place to integrate it? |
|
Date |
User |
Action |
Args |
2011-04-13 21:42:22 | torsten.becker | set | recipients:
+ torsten.becker, r.david.murray, sdaoden |
2011-04-13 21:42:21 | torsten.becker | link | issue11783 messages |
2011-04-13 21:42:21 | torsten.becker | create | |
|