Message132034
I’m probably the one with the least regrtest knowledge among us, but I like the general idea of moving the compat info from one huge dict into the tests themselves. It looks more readable and maintainable.
The new tests for test.support looks good.
I have a reputation to maintain, so here are some nits:
- “FS encoding” would be clearer as “filesystem encoding”.
- The argument names “required_on” and “optional” are not symmetrical.
- The indentation is hard to read here:
+pty = import_module('pty',
+ optional=['win32', 'os2emx', 'freebsd4', 'freebsd5', 'freebsd6',
+ 'freebsd7', 'freebsd8']) |
|
Date |
User |
Action |
Args |
2011-03-24 21:27:37 | eric.araujo | set | recipients:
+ eric.araujo, brett.cannon, pitrou, r.david.murray |
2011-03-24 21:27:37 | eric.araujo | set | messageid: <1301002057.59.0.0188286470982.issue10966@psf.upfronthosting.co.za> |
2011-03-24 21:27:37 | eric.araujo | link | issue10966 messages |
2011-03-24 21:27:36 | eric.araujo | create | |
|