This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author brandon-rhodes
Recipients belopolsky, benjamin.peterson, brandon-rhodes, daniel.urban, eric.araujo, ncoghlan, pitrou
Date 2011-03-21.12:55:00
SpamBayes Score 4.788968e-10
Marked as misclassified No
Message-id <87lj087hwc.fsf@asaph.rhodesmill.org>
In-reply-to <1300557523.71.0.236955804124.issue11572@psf.upfronthosting.co.za> (Nick Coghlan's message of "Sat, 19 Mar 2011 17:58:43 +0000")
Content
Nick Coghlan <report@bugs.python.org> writes:

> Regarding "__reduce__", other readers will have the same question Éric
> did, so that point should definitely go in a comment after the
> "__reduce_ex__" check.

I just sat down to review this issue, and, looking at test_copy3.patch,
isn't there already a comment next to each __reduce_ex__ check that
reminds the reader that object.__reduce_ex__ will itself call
__reduce__?  Does the comment just need to be more elaborate or
something?

Finally, Éric wants me to replace this:

>         self.assertTrue(issubclass(copy.Error, Exception))

with self.assertIsInstance().  But surely the question is not whether
copy.Error is an *instance* of Exception?  They are both instances of
*type*, right?  What I would need is something like assertIsSubclass or
assertInheritsFrom, neither of which exists.

So I think that test_copy3.patch already includes all of the valid
improvements on the table; if I'm missing one, just point it out and
I'll fix it!
History
Date User Action Args
2011-03-21 12:55:02brandon-rhodessetrecipients: + brandon-rhodes, ncoghlan, belopolsky, pitrou, benjamin.peterson, eric.araujo, daniel.urban
2011-03-21 12:55:00brandon-rhodeslinkissue11572 messages
2011-03-21 12:55:00brandon-rhodescreate