Message131136
This fix reveals a second bug. Without this fix, a non-existent file raises an IOError with an appropriate error message, but with the chained exception. After this fix, it raises an error that says 'not a gzip file', which while technically true is not very helpful :)
The correct IOError message only happened by accident in the original code, but we need to fix this second bug in order to fix the first one correctly. I suggest that the test case should read:
with self.assertRaisesRegex("xxx", IOError) as ex:
tarfile.open("xxx", self.mode)
self.assertEqual(ex.exception.errno, errno.ENOENT) |
|
Date |
User |
Action |
Args |
2011-03-16 16:40:57 | r.david.murray | set | recipients:
+ r.david.murray, Trundle, ev |
2011-03-16 16:40:57 | r.david.murray | set | messageid: <1300293657.39.0.907900682627.issue11513@psf.upfronthosting.co.za> |
2011-03-16 16:40:56 | r.david.murray | link | issue11513 messages |
2011-03-16 16:40:56 | r.david.murray | create | |
|