Message129860
Bill,
Thanks for the suggestion and the patch. It's a good idea, though I wonder whether you found that the bulk of the time spent in isEnabledFor() was actually spent in getEffectiveLevel()? That's the one which loops through a logger's ancestors looking for a level which is actually set, so intuitively it would take a while - especially for deeper levels in the logging hierarchy. If so (which I suspect to be the case, but it would be good to have you confirm it), a better solution may be to cache the effective level.
Roughly how deep are/were your logger hierarchies in the situation where you experienced performance problems?
I'm happy to look at caching effective level for Python 3.3: The 2.X branches are now closed for additions other than bugs and security issues. |
|
Date |
User |
Action |
Args |
2011-03-02 09:25:16 | vinay.sajip | set | recipients:
+ vinay.sajip, William.Hart |
2011-03-02 09:25:16 | vinay.sajip | set | messageid: <1299057916.25.0.577733312091.issue11369@psf.upfronthosting.co.za> |
2011-03-02 09:25:15 | vinay.sajip | link | issue11369 messages |
2011-03-02 09:25:15 | vinay.sajip | create | |
|