Author georg.brandl
Recipients Chris.Gerhard, anacrolix, benjamin.peterson, christian.heimes, daniel.urban, georg.brandl, loewis, pitrou, rosslagerwall
Date 2010-12-22.10:10:28
SpamBayes Score 1.61253e-06
Marked as misclassified No
Message-id <1293012633.05.0.0290802772015.issue4761@psf.upfronthosting.co.za>
In-reply-to
Content
Reference counting is not always correct.  For example, in unlinkat

    if (res < 0)
        return posix_error();
    Py_DECREF(opath);
    (return None)

the DECREF should be before the error check.  (Note that you can use the Py_RETURN_NONE macro to save INCREF'ing Py_None explicitly.)

Sometimes you use posix_error, sometimes posix_error_with_allocated_filename; is that deliberate?

Also, the documentation for each function should get ".. versionadded:: 3.3" tags.

Otherwise, this looks good and ready for inclusion when py3k is open for new features again.
History
Date User Action Args
2010-12-22 10:10:33georg.brandlsetrecipients: + georg.brandl, loewis, pitrou, christian.heimes, benjamin.peterson, daniel.urban, anacrolix, Chris.Gerhard, rosslagerwall
2010-12-22 10:10:33georg.brandlsetmessageid: <1293012633.05.0.0290802772015.issue4761@psf.upfronthosting.co.za>
2010-12-22 10:10:28georg.brandllinkissue4761 messages
2010-12-22 10:10:28georg.brandlcreate