This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients catlee, davide.rizzo, eric.araujo, georg.brandl, jhylton, orsenthil, pitrou, rcoyner, rhettinger, xuanji
Date 2010-12-01.10:06:23
SpamBayes Score 6.293408e-05
Marked as misclassified No
Message-id <1291197985.58.0.52800759882.issue3243@psf.upfronthosting.co.za>
In-reply-to
Content
Senthil:

+        try:
+           self.sock.sendall(data)

Indentation problem here.

+                if isinstance(data,str):
+                    content_length = len(data)

I'm not sure I understand. What does sending an unicode string mean?

+        # Check iterable body support
+        def iterable_body():
+            yield "one"
+            yield "two"
+            yield "three"

Iterables of strings? this doesn't seem supported in the patch.

Also, it would be nice if the tests checked that the sent data is as expected.
History
Date User Action Args
2010-12-01 10:06:25pitrousetrecipients: + pitrou, jhylton, georg.brandl, rhettinger, orsenthil, catlee, eric.araujo, rcoyner, xuanji, davide.rizzo
2010-12-01 10:06:25pitrousetmessageid: <1291197985.58.0.52800759882.issue3243@psf.upfronthosting.co.za>
2010-12-01 10:06:24pitroulinkissue3243 messages
2010-12-01 10:06:23pitroucreate