This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kristjan.jonsson
Recipients kristjan.jonsson
Date 2010-11-26.08:07:31
SpamBayes Score 1.3063988e-08
Marked as misclassified No
Message-id <1290758853.31.0.608837110631.issue10538@psf.upfronthosting.co.za>
In-reply-to
Content
The new "s*" code for PyArg_ParseTuple is used to fill a Py_buffer object from the arguments.  This object must be relased using PyBuffer_Release() after use.

However, if the object in the tuple does not support the new buffer interface, the old buffer interface is queried and the Py_buffer object is manually filled in.  For this case, the source object is _not_ increfed and buffer.obj remains set to 0.

This causes different semantics in the function for objects that are passed in:  If the Py_buffer interface is supported directly, then it is safe for the function to store this and release this at a later time.  If it isn't supported, then no extra reference to the object is got and the function cannot safely keep the Py_buffer object around.

The Fix is as follows:  Change line 1402 of getargs.c from:
PyBuffer_FillInfo(view, NULL, buf, count, 1, 0);
to
PyBuffer_FillInfo(view, arg, buf, count, 1, 0);
History
Date User Action Args
2010-11-26 08:07:33kristjan.jonssonsetrecipients: + kristjan.jonsson
2010-11-26 08:07:33kristjan.jonssonsetmessageid: <1290758853.31.0.608837110631.issue10538@psf.upfronthosting.co.za>
2010-11-26 08:07:31kristjan.jonssonlinkissue10538 messages
2010-11-26 08:07:31kristjan.jonssoncreate